Reading battle list

[Xleniz]

Hi, I got a real simple question
First:



monsterID = baseAddress + 0x007B0B4;
DWORD buffer;
byte monsterID3[15];
ReadProcessMemory(phandle,(void*)monsterID,&buffer, sizeof(&buffer),0);
ReadProcessMemory(phandle,(void*)buffer+0x124,&buffer, sizeof(&buffer),0);

(Now I have first, or second monster in battlelist)

Then


ReadProcessMemory(phandle,(void*)monsterID, &monsterID3, 15,0);


Gives only 4 characters (Cipf) and not Cipfried.
Even though I tell readprocessmemory to take 15 characters. Why is this?

Thanks.

<edit> Now I managed to make it more than 4 char, but its in ASCII. I have no idea how to make it
normal.

its like:


ReadProcessMemory(phandle,(void*)monsterID, &monsterID3[0],sizeof(monsterID3),0);
cout << monsterID3 << endl;

[XtrmJash]

Hi, I got a real simple question
First:



monsterID = baseAddress + 0x007B0B4;
DWORD buffer;
byte monsterID3[15];
ReadProcessMemory(phandle,(void*)monsterID,&buffer, sizeof(&buffer),0);
ReadProcessMemory(phandle,(void*)buffer+0x124,&buffer, sizeof(&buffer),0);

(Now I have first, or second monster in battlelist)

Then


ReadProcessMemory(phandle,(void*)monsterID, &monsterID3, 15,0);


Gives only 4 characters (Cipf) and not Cipfried.
Even though I tell readprocessmemory to take 15 characters. Why is this?

Thanks.

<edit> Now I managed to make it more than 4 char, but its in ASCII. I have no idea how to make it
normal.

its like:


ReadProcessMemory(phandle,(void*)monsterID, &monsterID3[0],sizeof(monsterID3),0);
cout << monsterID3 << endl;


Did you override the ReadProcessMemory function?

[Xleniz]

Override? No.

[ottizy]

What data type is monsterID3?

[XtrmJash]

What data type is monsterID3?

As he's reading the battle list, presumably 32 bit integer.

[Xleniz]

byte monsterID3[15];

[XtrmJash]

byte monsterID3[15];

You're reading a 32 bit integer, right? The creature ID from battle list? If so, it's stored at offset 0 from the battle list entry (before the name), and is only 4 bytes. Why are you declaring a 15 byte array?

[Xleniz]

no, im trying to get name.
I dont know what variable type I need, I tried char[15] and char* with no good results.

[ottizy]

std::string ReadString(DWORD address) {
char buffer;
std::string res;
while(1) {
ReadProcessMemory(handle, (void*)address, &buffer, sizeof(buffer), 0);
if (buffer == 0) break;
res += buffer;
address++;
}
return res;
}


This will work for reading names in battlelist.

[Xleniz]

Dont want to complain, but still only showing ascii.
(With: cout << ReadString(monsterID) << endl )

[XtrmJash]

Dont want to complain, but still only showing ascii.
(With: cout << ReadString(monsterID) << endl )

When you say it's showing ASCII, what exactly do you mean? What is the output? Hex? Random string? Numbers? Does the data represent the name?

[Xleniz]

A picture explains so much:
http://pbrd.co/13iaHlb

Btw, I recommend pasteboard.co, its a site where you just print screen, ctrl+v and its there:S

[ottizy]

Would you mind showing us some more of your code? How you are getting the handle, which address you're using etc.

[Xleniz]

Yes Sir!

Heres my 700 lines code



The text that you have entered is too long (23744 characters). Please shorten it to 10000 characters long.


Sorry.

Heres the part of it: (base address works)


GetWindowThreadProcessId(tibiaWindow,&pid);
phandle = OpenProcess(PROCESS_ALL_ACCESS,0,pid);
if(phandle) {
baseAddress = GetModuleBase(phandle, processName);
size_t bytesRead;
size_t bytestoRead = 50;
xPos = baseAddress + 0x553038;
yPos = baseAddress + 0x55303C;
testHex = baseAddress + 0x54F50C;
DMessage = baseAddress + 0x3BF0AC;
DWORD monsterID;
monsterID = baseAddress + 0x007B0B4;
DWORD buffer;
char* monsterID3 = new char[15];
ReadProcessMemory(phandle,(void*)monsterID,&buffer, sizeof(&buffer),0);
ReadProcessMemory(phandle,(void*)(buffer+0x128),&buffer, sizeof(&buffer),0);

char battleName[15] = "Hello";
int monsterID2;

while(1+1 == 2) {
if(GetAsyncKeyState(VK_LBUTTON && GetAsyncKeyState(VK_RBUTTON))) {
cout << ReadString(monsterID) << endl;
}
}


XDD

[ottizy]

Not really sure what you're trying to accomplish, but I guess it is to read all names in the battlelist.

Right now you're just reading baseAddress + 0x007B0B4 over and over again, which is pointing to nothing. The readstring function will read 1 byte from the memory until it finds a null character. Since the address you are reading isn't really pointing to a string it will keep on reading until it finds one, thus returning a value that makes no sense whatsoever.

If you want to read the battlelist I suggest you read some tutorials on how to do it on this forum.

[XtrmJash]

The battle list start address is currently 0x5A9530, so add that to Tibias base, add the offset for the name, and you should be hunky dory. (Offset for name = 4).

[Stiju]

char buffer[32];
ReadProcessMemory(hProcess, (void*)0x00F59534, (void*)buffer, 32, 0);
std::cout << "String: " << buffer << '\n';

And make sure to use the correct address.

[Xleniz]

I did Tibia.exe + 0x007B0B4, and did all of the stuff, to get it show correct address with full string in cheatengine,
I dont see why its wrong address.

Oh, I forgot
monsterID = buffer;

Well, now output is BLANK.
XDD